Border on my popup

csr500 · #1 Jul 15th, 2008, 20:22

Hello People

I am having some problems with a pop up window I am trying to create, i am new to Javascript so this has been take from http://www.javascriptkit.com/script/...opimage2.shtml

My problem is the border on the window.

I have resized my image and my pop up window so that it is the correct size, however I am still getting a border around the outside, which is annoying me a lot, however I am not JavaScript smart enough to work out where this border is getting added. I have tried altering my CSS file and I am still getting it.

Any help on the matter would be very very much appreciated.

Thanking everyone in advance for their time

Cameron

Bocaj · #2 Jul 15th, 2008, 21:03

Have you got a link to what you've got?

Also where is the border? On all sides, just on the top and left side?

csr500 · #3 Jul 16th, 2008, 19:02

Thank you for the quick response, click the images to see the problem.

As you can see from the link the border is at the top an the left, if I alter the size of the pop up window to be fine in Mozilla then it is wrong in IE and so on, but in a ideal world I would like to have zero border / margin / padding.

http://www.csr500.co.uk/websites/cape/alexis.html

Thank you for you time

Cameron

moojoo · #4 Jul 16th, 2008, 19:12

You may be better off implementing this using lightbox. To be honest pop up windows are annoying.

Bocaj · #5 Jul 16th, 2008, 19:47

i agree with moojoo, but for the method you're using

Code: Select all

// JK Pop up image viewer script- By JavaScriptKit.com
// Visit JavaScript Kit (http://javascriptkit.com)
// for free JavaScript tutorials and scripts
// This notice must stay intact for use

var popbackground="lightskyblue" //specify backcolor or background image for pop window
var windowtitle="Image Window"  //pop window title

function detectexist(obj){
return (typeof obj !="undefined")
}

function jkpopimage(imgpath, popwidth, popheight, textdescription){

function getpos(){
leftpos=(detectexist(window.screenLeft))? screenLeft+document.body.clientWidth/2-popwidth/2 : detectexist(window.screenX)? screenX+innerWidth/2-popwidth/2 : 0
toppos=(detectexist(window.screenTop))? screenTop+document.body.clientHeight/2-popheight/2 : detectexist(window.screenY)? screenY+innerHeight/2-popheight/2 : 0
if (window.opera){
leftpos-=screenLeft
toppos-=screenTop
}
}

getpos()
var winattributes='width='+popwidth+',height='+popheight+',resizable=yes,left='+leftpos+',top='+toppos
var bodyattribute=(popbackground.indexOf(".")!=-1)? 'background="'+popbackground+'"' : 'bgcolor="'+popbackground+'"'
if (typeof jkpopwin=="undefined" || jkpopwin.closed)
jkpopwin=window.open("","",winattributes)
else{
//getpos() //uncomment these 2 lines if you wish subsequent popups to be centered too
//jkpopwin.moveTo(leftpos, toppos)
jkpopwin.resizeTo(popwidth, popheight+30)
}
jkpopwin.document.open()
jkpopwin.document.write('<html><head><title>'+windowtitle+'</title><style type="text/css">*{margin: 0; padding: 0; border: 0;}</style></head><body '+bodyattribute+'><img src="'+imgpath+'" style="margin-bottom: 0.5em"><br />'+textdescription+'</body></html>')
jkpopwin.document.close()
jkpopwin.focus()
}

That'll fix it.

I've added a few settings in the popup to reset the browsers default settings

csr500 · #6 Jul 17th, 2008, 19:37

Thank you both very much for your help.

I have gone down the lightbox route, i will post the results when I have finished.

Once again thank you

Cameron

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
problem with border-right in FF	danny322	Web Page Design	9	Dec 6th, 2007 10:04
how to make the border be red	checkmate	Web Page Design	17	Oct 29th, 2007 07:47
CSS border styling	RZX Developer	Web Page Design	6	Aug 10th, 2007 14:25
Why only one border?	timmytots	Web Page Design	1	Nov 30th, 2005 21:32

		Webforumz.com > Main Forums > Design Your Website > Web Page Design
Border on my popup