[SOLVED] Visual Basic Help Please

Not sure if this is the correct place for this-sorry if not.

I have just started learning visual basic to try and add to my coding knowledge. I've been working on a simple calculator application that could be used in schools for young children. Basically, it asks the kids to enter 2 numbers into 2 seperate boxes. They then have to predict what the answer will be if the numbers are added/multiplied/subtracted/divided. They then click a button. There are 4 buttons (Add, multiply, divide, subtract) and they click one. The correct answer is displayed. That all works. I then tried to add a msgbox that would appear telling them whether they guessed right or not. This is where my problem lies. I have managed to right all the code, but I am getting an error 'End of Statement Expected) on the 'End If' text.

Code: Select all

PrivateSub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles lbAdd.Click
Label4.Text = " " + Str(Val(Text1.Text) + Val(Text2.Text))
If (guess.Text = Label4.Text) Then MsgBox("Well done, you guessed right") Else MsgBox("Unlucky, you guessed wrong")EndIf
 
EndSub

many thanks for your help.

Jack

To be honest, I think the compiler is confused.

I think if you space out the code, it will be fine. As a matter of coding practice, you should always use indentation on if else end if statements so you can clearly see whats going on. Always try to have lines of code that are not too long to aid readability. In the case of visual basic, the code is compiled so it doesnt matter how spaced out your source code is... make it as pretty as you like, the executable will always be the same size.

here is an amended code block:-

Code: Select all

Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles lbAdd.Click

    Label4.Text = " " + Str(Val(Text1.Text) + Val(Text2.Text))
    If (guess.Text = Label4.Text) Then
        MsgBox("Well done, you guessed right")
    Else 
        MsgBox("Unlucky, you guessed wrong")
    End If
End Sub

As a sidse note, please rememeber that syntax is crucial. Privatesub, endif and endsub are NOT valid syntax.

Private sub, end if, end sub..... those are valid - note the spacing!

Good luck!

__________________
Click the 'Thanks!' button if this post has helped you

Rob - Webforumz Founder

Thank you! That got rid of the error. However, it then wasn't giving the right message box-it would always give an incorrect answer. For those who would like to know, here is the correct code:

Code: Select all

Label4.Text = Val(Text1.Text) + Val(Text2.Text)
If (guess.Text = Label4.Text) Then
MsgBox("Well done, you guessed right")
Else
MsgBox("Unlucky, you guessed wrong")
EndIf