PHP Form returns error : mail expects most 5 parameters?

[shifty]

My php code looks like this:

PHP: Select all

<?
  $name  = $_REQUEST['name'] ;
  $email = $_REQUEST['email'] ;
  $day   = $_REQUEST['day'] ;
  $month = $_REQUEST['month'] ;
  $year  = $_REQUEST['year'] ;
  $message = $_REQUEST['message'] ;
  
  mail( "myemailadress-removed-here.com", "Message from vistor",
    $name, $email, $day, $month, $year, $message, "From: $name" );
  header( "Location: http://www.example.com/thankyou.html" );
?>

My form is the second form here: http://www.welovespuds.com/contact_us/contact.html

However, I get the folling error message in my browser when the form is submitted:


Warning: mail() expects at most 5 parameters, 9 given in d:\websites\welo381573\www\contact_us\message.php on line 10

Warning: Cannot modify header information - headers already sent by (output started at d:\websites\welo381573\www\contact_us\message.php: 10) in d:\websites\welo381573\www\contact_us\message.php on line 11

(Try it for yourself..)

>Can anyone help? Is it true what the error message seems to imply that a mail() can only take a max of 5 parameters? If so, what is the way around this?

Thanks

[grahame]

You have 9 parameters to your main command, which is too many.

The first parameter should be the destination email address. That's fine
The second should be the subject. That looks good too.

The third should be the body of the email. This is where I think you have gone wrong - you probably meant to write everything form $email through to $message in the email body, but that's not what you've done. I suggest you write
$embody = "$email $day $month $year $messge";
before your mail command, then just use $embody in your mail() function call.

The last parameter you gave to mail is fine too.

[ukgeoff]

Regarding your second error message:
Header information is sent to the browser as soon as the page starts being processed. When you are going to use redirection, which is what you effectively are doing, you need to buffer the header output until you are ready to send it.

You do this by having:

Code: Select all

ob_start();

at the very begining of the page and once you have got to the end of your php processing, make the last command;

Code: Select all

ob_end_flush;

[grahame]

Originally Posted by ukgeoff

Regarding your second error message:
Header information is sent to the browser as soon as the page starts being processed. When you are going to use redirection, which is what you effectively are doing, you need to buffer the header output until you are ready to send it.

You do this by having:

Code: Select all

ob_start();

at the very begining of the page and once you have got to the end of your php processing, make the last command;

Code: Select all

ob_end_flush;

Yes, Geoff ... but the second message may have been caused by the warning message about the email, mightn't it? So sort out the email issue and the header issue goes away anyway?

[shifty]

Thank you both Geoff and Graeme.

Yes the second error did resolve itself after fixing the intial problem... All is working now, thanks!

[BADmd]

I tried to configure as previously mentioned code below :

PHP: Select all

<?
  $First_Name = $_REQUEST['First_Name'] ;
  $Last_Name = $_REQUEST['Last_Name'] ;
  $Phone = $_REQUEST['Phone'] ;
  $Email_Address = $_REQUEST['Email_Address'] ;
  $Comments = $_REQUEST['Comments'] ;
  $EmMsg = "$First_Name $Last_Name $Phone" ;

  mail( "formsubmit@emailaddress.com", "Form Submit",
  $EmMsg,$Comments, "From: $Email_Address" );
?>

I am now getting an internal server error

Internal Server Error

The server encountered an internal error or misconfiguration and was unable to complete your request. Please contact the server administrator, support@supportwebsite.com and inform them of the time the error occurred, and anything you might have done that may have caused the error.
More information about this error may be available in the server error log.

Apache/1.3.33 Server at www.domain.com Port 80

In my email however, I can get the first and last name, phone number, and comments. I can not get the email address. Please help.