Directory listing using PHP

[djeyewater]

Hi

I am trying to write a script that makes a tree style menu out of my site's directory structure. I have the script written, and it works but I'm pretty new to PHP and would appreciate it if anyone could have a quick look at the script to see if there would be a more efficient way of doing this.

Basically the script loops through the directories and makes them a link that toggles (using js) the display of any directories below it. If a directory contains a directory (or file) named 75DPI then it instead becomes a link back to the index with the filepath to that directory appended to the URL. Hope that makes sense!

PHP: Select all

function getNav($path, $i)
{
    $nav = opendir($path);
    while($file = readdir($nav))
    {
        if($file != '.' && $file != '..' && $file != '300DPI')
        {
            if (is_dir($path.'/'.$file))
            {
                $dirContents = scandir($path.'/'.$file);
                if (in_array('75DPI', $dirContents))
                {
                    echo '<li><a href="index.php?path='.$path.'/'.$file.'">'.$file.'</a></li>'."\n";
                    $i++;
                }
                else
                {
                    echo '<li><a href="javascript: expand(\'dir'.$i.'\');">+'.$file.'</a></li>'."\n";
                    echo '<ul id="dir'.$i.'">'."\n";
                    $i++;
                    getNav($path.'/'.$file, $i);
                    echo '</ul>'."\n";
                }
            }
            $i++;
        }
    }
    closedir($nav);
}

getNav('Img', 1); 

[CloudedVision]

its the most efficient way of doing it i can think of


Also, this is the correct way to loop through readdir (don't ask me why, it was on the PHP site.)

PHP: Select all

while(false !== ($file = readdir($handle))) 

[djeyewater]

Cool, thanks for checking it. The only reason I can see for using

PHP: Select all

while(false !== ($file = readdir($handle))) 

is so it would work if you have a directory or file named 0 (since 0 evaluates to false but is not identical to false).

[RohanShenoy]

did you try using the scandir() function?But I think its available only in PHP 5 and above.

[djeyewater]

I did try scandir (in fact the function uses scandir to check whether the folder contains a file or folder named '75DPI') but I couldn't figure out how to make the function work in the same way.