Why is this not working!

[Jack Franklin]

Ok, sort of related to my other thread but just a simple problem. Take this class:

PHP: Select all

class content {
var $selector;
var $table;
//START OF CONTENT CLASS
    function connect_db($user, $db) {
        $conn = mysql_connect("localhost", "root", "") or die(mysql_error());
        mysql_select_db($db, $conn) or die(mysql_error());
    }

    function get($thetable, $theselector) {
    $this->selector = $theselector;
    $this->table = $thetable;
    if (mysql_query("SELECT '$selector' FROM '$table'")) {
    echo 'Query Fine';
    }                
}
} 

Nothing to tricky there? In the function GET it just adds the variables to the query.

On the home page:

PHP: Select all

$all = new content;
$all->connect_db(root, test);
$all->get(content, name); 

Except it doesn't work. Obviously nothing displays, but I should get a nice message telling me it's all fine. Now, if I replace:

PHP: Select all

    if (mysql_query("SELECT '$selector' FROM '$table'")) { 

With

PHP: Select all

    if (mysql_query("SELECT '$selector' FROM content")) { 

It works. Anyone help me figure out why it wont work with a variable in there?

The error MySQL gives (added error report thingy) is:

Originally Posted by Annoying MySQL

Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '''' at line 1

[CloudedVision]

Try this as your SQL query:

PHP: Select all

mysql_query("SELECT `$selector` FROM `$table`") 

Not sure if that would work, but give it a try.

[Jack Franklin]

Nope, error. Wrong table name.

[CloudedVision]

Hmmmm..... What's the query that the PHP is generating?

[aihazm]

i think is just due to the quotes; try removing them :
'$table' -> $table

[Jack Franklin]

No luck.

Oh well. Don't worry, I've given up anyway, it was getting to complex for me.

[implrm]

Surely you are not naming the right variable i.e. you have $selector when you should be using $theselector or $this->selector

|This would also seem correct due to the error message as $selector isn't one of the defined variables therefore you will be passing "Select '' from '' " as a query.

[Jack Franklin]

implrm you are a genius! As are the others! Turned out I had a typo, so aihazm's suggestion was right. The line now looks like:

PHP: Select all

    $sql = mysql_query("SELECT $this->selector FROM $this->table"); 

As I said this is my first time using OOP really so I'll be making some mistakes! Thanks all.