[SOLVED] Random String Verification help

[psycho wolvesbane]

Hello. In a form I've made I have tried to create a random string variable that is displayed on the form and for the users to copy into another text box for comparison and validation, however it doesn't seem to work as it doesn't display anything in the table beyond the Verification Required: text.

Here is the Javascript function I am using to create the random string:

Code: Select all

function random_string($len=5, $str='')
{
   For($i=1; $i<=$len; $i++)
   {
      $ord=rand(48, 90);
      if((($ord >= 48) && ($ord <= 57)) || (($ord >= 65) && ($ord<= 90))) 
      {
         $str.=chr($ord);
      }
      else
      {
         $str.=random_string(1);
      }                                           
   }
   return $str;
}

Here is the section of the form where the random string gets placed:

Code: Select all

   <tr><td><span class="errmsg">* </span><span class="head4">Verify Registration <br />(Copy the text exactly):</span>
   </td><td><?php $rand_str=random_string(5);?> 
   <span class"head2"><?php echo $rand_str?></span> 
   <?php $_SESSION['Rand_str']= $rand_str?></td></tr>
   <tr><td></td><td width="300"><label><input type="text" maxlength="5" name="Verify"/></label> <?php unset($rand_str)?></td></tr>

Now I also get an error message saying: missing ) after formal parameters
function random_string($len=5, $str='')\n

Can anyone help?

[CloudedVision]

Moved to PHP forum

Here is the Javascript function I am using to create the random string:

It's PHP, not javascript, so i think thats where your error is coming from. Instead of using <script></script> use <?php ?> That'll make the server execute it as PHP.

[alexgeek]

It helps to put a space between code and the closing tags, instead of:

PHP: Select all

<?php $rand_str=random_string(5);?> 
<?php echo $rand_str?>

Use:

PHP: Select all

<?php $rand_str=random_string(5); ?> 
<?php echo $rand_str; ?>

Cloud is right though,this is not javascript so there error is probably caused by mixing html and php incorrectly.

[psycho wolvesbane]

Originally Posted by alexgeek

It helps to put a space between code and the closing tags, instead of:

PHP: Select all

<?php $rand_str=random_string(5);?> 
<?php echo $rand_str?>

Use:

PHP: Select all

<?php $rand_str=random_string(5); ?> 
<?php echo $rand_str; ?>

Cloud is right though,this is not javascript so there error is probably caused by mixing html and php incorrectly.

I've never noticed any problem with not having spaces when it's a single variable being echo'ed. Anyway it worked fine once I moved it into some php tags. The place I got the original script wasn't very clear on if it was PHP or Javascript and since it mostly looked the same way as JS functions do I couldn't tell the difference. Thanks for the help!