Adding 1 to Column Value

[Jack Franklin]

Each row in my table 'content' stores a different post, and the end colum is called 'views'. When a post is viewed, I want to add 1 to the column 'Views', so I can display a list of the top viewed posts in the side bar. This is my current code:

PHP: Select all

$contentid = $_GET['contentid'];

$views = mysql_query("SELECT views FROM content WHERE contentid='$contentid'");
while ($no_views = mysql_fetch_array($views)) {
$views_before = $no_views['views'];
$views_after = $views_before+1;
$updateviews = "UPDATE content SET
views='$views_after'
WHERE contentid='$contentid'";
if($updateviews) {
echo 'OK';
} else {
echo 'NO';
}
} 

When I run it it seems not to run, I don't see 'OK' or 'NO', and I surely should be seeing one or the other?
I bets it's some stupid mistake. I'm willing to bet it's this line:

PHP: Select all

$views_after = $views_before+1; 

But even if that failed I should still be seeing an error?

Thanks,

Jack

[Jack Franklin]

Ok. I was uploading it to the wrong place! DUH! But there is still a problem:

PHP: Select all

$contentid = $_GET['contentid'];
$views = mysql_query("SELECT views FROM content WHERE contentid='$contentid'");
while ($no_views = mysql_fetch_array($views)) {
$views_before = $no_views['views'];
$views_after = $views_before+1;
echo $views_before;
echo $views_after;
$updateviews = "UPDATE content SET
views='$views_after'
WHERE contentid='$contentid'";
if($updateviews) {
echo 'NO';
} else {
echo 'NO';
}
} 

When you load the page it echos the variables $views_before & $views_after. That always returns '0 1' because the data is not being added to the table content. Therefore there must be an error with the MySQL bit. Ideas please!

[Jack Franklin]

i'm now guessing it might be the table structure? If it helps, here it is:

Also, if you look at any post on my site, you'll see the text: 01Y above the title. This says the views before, views after, and then if the sql UPDATE has worked. So, it's saying it has?

[Rakuli]

Umm... You're really overcomplicating the matter

You don't need to fetch anything from the database at all. You have the views with a default value of 0 so all you need to do is.

PHP: Select all

// Update the views



mysql_query("UPDATE content SET views = views+1 WHERE contentid=$contentid");



// Then retrieve the data 



$result = mysql_query("SELECT views FROM content WHERE contentid=$contentid");



$row = mysql_fetch_assoc($result);



// echo views before



echo $row['views']-1;



// echo views after



echo $row['views']; 

That will update it without having to bring PHP into the story at all MYSQL is much quicker than PHP so whenever you can use mysql's functions and logic, use it.

[Jack Franklin]

Bloomin hell, why the hell did I do all of that when I needed just one line. Thanks Rakuli. I'll try it right away

I LOVE YOU RAKULI! Thanks a lot, I cannot belive I spent a good hour bashing my head on the desk when I only needed one bloomin line.