problem with my form script?

[GeekyBabe]

This is the first php I have ever written, and I want to check if its correct.

I created a form in dreamweaver that includes
-a text box
-a file upload
-three check boxes
-submit button.

I wrote this code in hopes to send the info to my e-mail address:

PHP: Select all

<?php
  $email = $_REQUEST['Email'] ;
  $file = $_REQUEST['Image'] ;
  $check1 = $_REQUEST['1'] ;
  $check2 = $_REQUEST['2'] ;
  $check3 = $_REQUEST['3'] ;
  $submit = $_REQUEST['Submit'] ;


  mail( "info@changedforprivacy.com", "New Sent Photo",
    $message, "From: $email" );
  header( "Location: http://www.changedforprivacy.com/SendSuccess.html" );
?>

The form in dreamweaver has the action: process.php which is the name of the code file.

Is this looking correct?

I inputted everything into my hosting server, but it doesnt work, infact, while in firefox it opens up a blank mail window, and it never redirects anyone to the send success page. In internet explorer, when I mouseover the submit button, it shows an mailto e-mail address I had origionally tried adding, but I removed that yesterday, so i dont understand why its still showing up. Is it just the updates I make in dreamweaver dont take affect immediatly on the server?

Please help!


EDIT: wow I actually got it to work now, I just uploaded it in the wrong spot on the server, the mail went through, but the results of the form did not show up in the e-mail, and the sent file was not there either. So what should I do to my script to fix this? I'm completely puzzled.

[jimz]

You need to assign a value to $message.

eg...

PHP: Select all

<?php
  $email = $_REQUEST['Email'] ;
  $file = $_REQUEST['Image'] ;
  $check1 = $_REQUEST['1'] ;
  $check2 = $_REQUEST['2'] ;
  $check3 = $_REQUEST['3'] ;
  $submit = $_REQUEST['Submit'] ;

$message = "
Email address = $email
Checkbox1 = $check1
Checkbox2 = $check2
Checkbox3 = $check3";

  mail( "info@changedforprivacy.com", "New Sent Photo",
    $message, "From: $email" );
  header( "Location: http://www.changedforprivacy.com/SendSuccess.html" );
?>

Attaching a file might be a bit tough for you, seeing as you're just starting out with php.

Give that a go without the file for now, and see if you get the rest of the data sent to you in an email.

[ScottR]

Your next step is to start validating that data. Spammers will use that form to send out mass emails. Since your using $_REQUEST instead of $_POST (assuming your action is post), they can append extra data to the URL.

[Jack Franklin]

I find using $_POST is the best way to send the data, although I understand it is your first attempt. Can I see your html for the code please?

[GeekyBabe]

heres the code for my form in dreamweaver:

HTML: Select all

<form action="process.php" method="post" enctype="multipart/form-data" name="Form" class="style1" id="Form">
      
    <div align="left">
            <blockquote>
              <p><span class="style11">E-mail:          </span>
                <input type="text" name="Email" id="Email" />
                <br />
                <span class="style6">I have text here</span><br />
                <br />
                <br />
                <span class="style11"> Image:</span>
                <input type="file" name="Image" id="Image" />
                <br />
                <br />
                <br />
                <span class="style12">more text here</span><br />
                <br />
                <input type="checkbox" name="1" id="1" />
                standard retouch  <br />
                <span class="style6">blah blah checkbox</span><br />
                <input type="checkbox" name="2" id="2" />
                anothercheckbox description<br />
                <input type="checkbox" name="3" id="3" />
                last checkbox<br />
                <br />
                More options will be added in the near future!<br />
                <br />
                <br />
                <input type="submit" name="Submit" id="Submit" value="Submit" />
                <span class="style6">final text</span><br />
                <br />
              </p>
            </blockquote>
          </div>
    </form>