[SOLVED] PHP variable handling problems

[DerrickE]

Basically my database is setup like this:

sections -> id,sid,name
menu -> item,sid

the menu sid corresponds with the section id

The code below is supposed to pull the section id from the sections table and then for every section, it is supposed to pull the menu item that belongs in that section.

Section1 has 3 items
item1 from section1
item2 from section1
item3 from section1

Section2 has 1 item
item1 from section2
item2 from section2

Section3 has 4 items
item1 from section3
item2 from section3
item3 from section3
item4 from section3


The first loop works fine, it picks up the correct section ids.
The second loop to pick up the actual items in the section fails. It acts like it is looping through(ie. every section gets the # of items it actually has) But the data is from the 1st section only. ie, the 2nd and 3rd and 4th sections all contain the data from the 1st section.


It actually looks like this: (please note the section# from which it is pulling the item....different from above)

Section1 has 3 items
item1 from section1
item2 from section1
item3 from section1

Section2 has 1 item
item1 from section1
item2 from section1

Section3 has 4 items
item1 from section1
item2 from section1
item3 from section1

PHP: Select all

$sql = "SELECT * FROM sections where rid='$rid' ORDER BY sid";

$content .= $sql."<br>";

$modextra = "<hr><h1>Non-Sectioned</h1>";

$result = mysql_query($sql) or die(mysql_error());

$nrows = mysql_num_rows($result);

while($row = mysql_fetch_array($result)) {

    $secid[] = $row['id'];

    $sname[] = $row['name'];

}

for($j = 0; $j < $nrows; $j++) {

$content .= "<hr><h1>$sname[$j]</h1>";

$content .= "<TABLE BORDER=1 cellpadding=5 cellspacing=0 align=center width=100%>\n";

$sql = "SELECT * FROM menu where rid='$rid' AND sid='${$secid[$j]}' ORDER BY id";

$content .= $sql."<br>";

$result = mysql_query($sql) or die(mysql_error());

$rows = mysql_num_rows($result);

while($row = mysql_fetch_array($result)) {

    $id[] = $row['id'];

    $iname[] = $row['iname'];

    $idesc[] = $row['idesc'];

    $iprice[] = $row['iprice'];

    $iextra1[] = $row['extra1'];

    $iextra2[] = $row['extra2'];

    $isid[] = $row['sid'];



}

for($i = 0; $i < $rows; $i++) {

    $content .= " <TR>\n";

    $a = $i;

            $content .= "<TD valign=top width=200><font style=\"font-size:8pt;\"><b>ID:</b> ". $id[$a] ."<br><b><a name=\"". $id[$a] ."\">Name:</a></b> ". $iname[$a]."<br><b>Price: </b>".$iprice[$a]."</font></td><td><font style=\"font-size:8pt;\"><b>Extra1: </b>".$iextra1[$a]."<br><b>Extra2: </b>".$iextra2[$a]."</font></td><td><b>Description:</b><br> ". $idesc[$a] ."</td><td><input type=button value='Delete Item' onclick=\"document.location='menuitemdelete.php?i=confirm&rid=".$rid."&id=$id[$a]'\"><br><input type=button value='Modify Item' onclick=\"document.location='menu_itemmod.php?id=$id[$a]'\"></td>";

    $content .= " </TR>\n";

}

$content .= "</TABLE>\n"; 

[c010depunkk]

I think your problem is here:

PHP: Select all

$sql = "SELECT * FROM menu where rid='$rid' AND sid='${$secid[$j]}' ORDER BY id"; 

Shouldn't "rid" be "id?"

[DerrickE]

No. Sorry I forgot to put that in the database section. rid is the restaurant id. I'm pulling the items from that restaurant only where the sid is the section id and ordering them id.

[c010depunkk]

where does the main FOR loop end? There's a missing "}".

[Rakuli]

Hi there,

The loops don't appear to be necessary.

I changed your code a bit, this way you can tell for sure if it;s the query that is wrong because the loops are inside of loops.

PHP: Select all

<?php

sql = "SELECT * FROM sections where rid='$rid' ORDER BY sid";

$content .= $sql."<br>";

$modextra = "<hr><h1>Non-Sectioned</h1>";

$result = mysql_query($sql) or die(mysql_error());

$nrows = mysql_num_rows($result);

while($row = mysql_fetch_array($result)) {



    $content .= '<hr><h1>' . $row['name'] . '</h1>

                <TABLE BORDER=1 cellpadding=5 cellspacing=0 align=center width=100%>' . "\n";

                

    $sql = "SELECT * FROM menu where rid='$rid' AND sid='${$row['id']}' ORDER BY id"; // sid='$ ?? is that right?

    

    $content .= $sql . '<br />';

    

    $result2 = mysql_query($sql) or die(mysql_error());

        

        while ($row2 = mysql_fetch_assoc($result2))

            

            $content .= '<tr>

                            <td valign="top" width="200" style="font-size: 8pt"><strong>ID : </strong>' . $row2['id'] . '<br />

                                                                                <strong><a name="' . $row2['id'] . '">Name : </a></strong>' . $row2['iname'] . '<br />

                                                                                <strong>Price : </strong> ' . $row2['iprice'] . '

                            </td><td style="font-size: 8pt">                    <strong>Extra1 : </strong> ' . $row2['extra1'] . '<br />

                                                                                <strong>Extra2 : </strong> ' . $row2['extra2'] . '

                            </td><td style="font-size: 8pt">                    <strong>Description : </strong> ' . $row2['idesc'] . '

                            </td><td style="font-size: 8pt">                    <input type="button" value="Delete Item" onclick="document.location=\'menuitemdelete.php?i=confirm&amp;rid=' . $rid . '&amp;id=' . $row2['id'] . '" /><br />

                                                                                <input type="button" value="Modify Item" onclick="document.location=\'menu_itemmod.php?id=' . $row2['id'] . '" />

                            </td>

                        </tr>';

                                                                                

    

}



$content .= '</table>';

?>

Let me know how it goes,

Cheers

[DerrickE]

Had to modify a few things to fit it in with the rest of the code, but it works great

I think I was just making it too complicated. Remember KISS

Thanks a lot.