[SOLVED] PHP Contact Form

[Stuart]

Hello,

I am new to php and am having a slight problem. The contact form I have on my website is submitted through php. When the user clicks 'Submit', the send.php page displays a message which tells the user if the form was submitted correctly or if s/he entered something wrong. It works fine except that all the HTML after the php code is missing. In other words, the php overwrites anything that comes after it.

My code is:

PHP: Select all

<?php

$name = $_POST['name'];
$email = $_POST['email'];
$type = $_POST['type'];
$url = $_POST['url'];
$message = $_POST['message'];
$ip = $_POST['ip'];
$browser = $_POST['browser'];


if (eregi('http:', $message)) {
echo "<p align=\"center\" class=\"style1\">Please enter the http: address into the URL field</p>";
exit ("<p align=\"center\" class=\"style2\"><a href=\"javascript:history.back();\">Return to form</a></p>");
}
if(!$email == "" && (!strstr($email,"@") || !strstr($email,".")))
{
echo "<p align=\"center\" class=\"style1\">Invalid email address entered";
$badinput = "Please try again</p>\n";
echo $badinput;
exit ("<p align=\"center\" class=\"style2\"><a href=\"javascript:history.back();\">Return to form</a></p>");
}

if(empty($name) || empty($email) || empty($message )) {
echo "<p align=\"center\" class=\"style1\">Please fill in all required fields</p>\n";
exit ("<p align=\"center\" class=\"style2\"><a href=\"javascript:history.back();\">Return to form</a></p>\n");
}

$today = date("l, F j, Y, g:i a") ;

$type = $type ;
$subject = "Contact the Webmaster";

$message = stripcslashes($message);

$message = "Date sent: $today [EST] \n
From: $name ($email)\n
URL : $url \n
Message Type: $type \n
Message: $message \n
User IP: = $ip \n
Browser Info: $browser \n
";

$from = "From: $email\r\n";


mail("MyEmail@yahoo.com", $subject, $message, $from);

?>

<p align="center" class="style1">Your message has been submitted successfully...</p>
<p align="center" class="style2">Thank you for helping us improve our website</p>

The two <p> tags at the end are the message that is displayed if there are no errors in the form. But everything after those <p> tags is completely gone...

Any help would be much appreciated.

Thanks,
SWagner

[Rakuli]

It's because you're calling the exit() function on an error, this stops the script and won't put anything else out.

Or do you mean that it won't display when everything validates? If this is the case, try wrapping all the variables you use between double quotes ie. " in curly braces to make sure PHP isn't getting confused amongst the special characters.

PHP won't overwrite anything as it works from top to bottom, you may wish to check your error long to be sure there aren't any hard-to-see sytax errors.

Let me know how you go.

Cheers,

[Stuart]

OK, I see what you mean. However, the exit(), or die(), function is needed so that the incomplete email is not sent to me. How do I still use the exit()/die() function without the rest of my page being cut off?

[Rakuli]

Okay, instead of exiting on error, just store the errors in an array to output. This will allow you to check error before sending mail...

PHP: Select all

<?php



$name*=*$_POST['name'];

$email*=*$_POST['email'];

$type*=*$_POST['type'];

$url*=*$_POST['url'];

$message*=*$_POST['message'];

$ip*=*$_POST['ip'];

$browser*=*$_POST['browser'];



$errors = array();  // start an empty array





if*(eregi('http:',*$message))*{

$errors[] = *"<p*align=\"center\"*class=\"style1\">Please*enter*the*http:*address*into*the*URL*field</p>";

}

if(!$email*==*""*&&*(!strstr($email,"@")*||*!strstr($email,".")))

{

$errors[] = *"<p*align=\"center\"*class=\"style1\">Invalid*email*address*entered</p>";

}



if(empty($name)*||*empty($email)*||*empty($message*))*{

$errors[] = *"<p*align=\"center\"*class=\"style1\">Please*fill*in*all*required*fields</p>\n";



}



// Check for errors before sending email



if (!count($errors)) 

{





$today*=*date("l,*F*j,*Y,*g:i*a")*;



$type*=*$type*;

$subject*=*"Contact*the*Webmaster";



$message*=*stripcslashes($message);



$message*=*"Date*sent:*$today*[EST]*\n

From:*$name*($email)\n

URL*:*$url*\n

Message*Type:*$type*\n

Message:*$message*\n

User*IP:*=*$ip*\n

Browser*Info:*$browser*\n

";



$from*=*"From:*$email\r\n";





mail("MyEmail@yahoo.com",*$subject,*$message,*$from);

} else {



// now output the errors for user to see



foreach ($errors as $msg) 

     echo $msg;



echo '<p*align=\"center\"*class=\"style2\"><a*href=\"javascript:history.back();\">Return*to*form</a></p>';



}





?>



<p*align="center"*class="style1">Your*message*has*been*submitted*successfully...</p>

<p*align="center"*class="style2">Thank*you*for*helping*us*improve*our*website</p>

[Stuart]

Thanks. It works great.
SWagner

PS: Why did you replace almost every space with a '*'?

[Rakuli]

I didn't put the asterix there

That's really weird.. sorry about that.

[Stuart]

That's ok. I just used the 'Find and Replace' option in Dreamweaver to replace any asterisk with a space...

[Stuart]

Also, I have several checkboxes in my form. The problem is that only one of the values (if more than one is checked) is sent to me by email. Why is that, and how do I fix it?

[Rakuli]

Checkboxes all have to have a different name or else the last one will overwrite the previous one.

[Stuart]

OK, thanks.