successful query?

[alexgeek]

to check if a query was succesful, is the php if statement just;

PHP: Select all

if (mysql_query($query) or die ($error->error()) {
// do this if it happened
} else {
//if it didn't
} 

The or die bit refers to my errors class

[jimz]

PHP: Select all

if (mysql_query($query) or die ($error->error()) {
// do this if it happened
} else {
//if it didn't
} 

hmmm.... I didn't test it, but I think it should work.

mysql_query() returns either the results if successful, or FALSE if not.

die() does not return any values, so I think it should work!

Although, maybe this would be a better way of writing it?:

PHP: Select all

if($result=mysql_query($query))
{
    // do this if it happened
}
else
{
    die($error->error());
} 

Guess it's just what's easiest to read for you...

[alexgeek]

PHP: Select all

if($result=mysql_query($query) or die ($error->error())
{
    // do this if it happened
}
else
{
    die($error->error());
} 

would that work aswell?

[hschmitz]

The die statement will always take precedence when the mysql query fails. This means that, if mysql_query returns false, then die(...) is executed, ending the script immediately.

The else part of the if statement will then never be executed.

[hschmitz]

Originally Posted by jimz

die() does not return any values, so I think it should work!

die() never returns at all. It's a synonym for exit() which exits the script immediately without running another line of code, except for the destructors of already existing objects.

[alexgeek]

sorry...
i just realised my mistake.
thanks guys

[afmanuk]

Thing is, if($result=mysql_query($query)) ...
Will always return true as the return value (true, false, or result set) will be set to the $result variable.
I think that

PHP: Select all

if(!($result = mysql_query($query))) {
//Failure stuff first
} else {
//Success stuff here
} 

This should be better as it will always return false on error, but will only return true if the query is UPDATE, DELETE, DROP, etc...

[alexgeek]

what about

PHP: Select all

$result = mysql_query($query);
if (!$result) {
//success
} else {
//fail
} 

?

[afmanuk]

Success and fail the other way round, cause you're checking whether $result is false. But yeah... That's good

[alexgeek]

cheers