Login Script... something wrong!

[snowangel]

Hi!
Okay, first of all, I'm a beginner of PHP... I've thought of a login script for my site, it begins with a form where one has to fill in username and password, and the action file of this form is the following (user authentication is done with a flat file):

PHP: Select all

<?PHP
    $user = $_POST['username'];
    $pass = $_POST['passwd'];

    $file = 'data/userfile.txt';
    $filecontents = file($file) or die('Can\'t open/read file');
    foreach ($filecontents as $fileline) {
        $pieces = explode(':', $fileline);
        if(strtolower($pieces[0]) == strtolower($user) && $pieces[1] == $pass) {
            echo "YES!!!";
            break;
        }
    }
?>

As you can see, I just wanted the script to display a message to see if it works. Well, it does, but just if I use the last username and password of the user file... I'm sure it has to be something with the foreach() part, but I just can't figure out what it could be :-(
I guess it is easy for you to find the error, please be patient, I'm really a beginner!!
Thanks in advance if you can help!

[Pheonix]

What are the contents of the file?
As far as I can tell the problem is that you are treating the file contents as if they are an array, and as far as I cant tell you have not done anything to convert the data your loading into an array.

[snowangel]

Contents of the file:

Code: Select all

user1:pass1
user2:pass2
user3:pass3

I've used quite a lot print_r(), so here are the contents:

print_r($filecontents):

Code: Select all

Array ( [0] => user1:pass1 [1] => user2:pass2 [2] => user3:pass3 )

print_r($pieces), written in the loop, so there are 3 lines:

Code: Select all

 Array ( [0] => user1 [1] => pass1 ) 
Array ( [0] => user2 [1] => pass2 ) 
Array ( [0] => user3 [1] => pass3 )

print_r($pieces) at the very end of the script, after the last "}":

Code: Select all

 Array ( [0] => user3 [1] => pass3 )

What do you mean by "converting the data I'm loading into an array"? I just can't figure out where the bug is... it works only when I'm using user3's data... maybe because only those data are left after the foreach() loop (look at the last output)?

[Pheonix]

Well, looks like you have done everything correctly...
I'm going to guess the problem is with the if statement.
put something like this before the if statment, so you can compair the two varables yourself.

PHP: Select all

echo '"'.strtolower($pieces[0]).'" == "'.strtolower($user).'" && "'.$pieces[1].'" == "'.$pass.'")'; 

I have a suspision you might end up with something like
"pass1
"
Where it has a line break after it.
Other then the varable not being equal... I can't figure out what might be wrong.

[snowangel]

Okay, good idea!
This is the output I get:

Code: Select all

"user1" == "user1" && "pass1 " == "pass1""user2" == "user1" && "pass2 " == "pass1""user3" == "user1" && "pass3" == "pass1"

I think I see the problem! after pass1 and pass2, there's a free space! But why? In the userfile, I just pressed enter, there isn't anything after the data.

[Pheonix]

No idea, but check out trim() it should be able to fix your problem.

[snowangel]

Okay, stupid question, but I don't know all the functions, anyway, thanks!
It's working!!! Perfectly!!! I love you guys, thank you so much for being so patient and helping soooo much!!