Login/register

[alexgeek]

yes:

PHP: Select all

<?php
require_once('/User/connectweb.php');
$form = "<form action="/User/login.php" method=\"post\">Username:<br><input type=\"text\" name=\"user\"><br>Password:<br> <input type=\"password\" name=\"pass\"><br> <p align=\"center\"><input type=\"submit\" action=\"submit\" name=\"login\" value=\"login\"> </p> </form><p>Haven't got an account? Register</p><p>Forgot your password?</p>";
 
    if (!isset($_SESSION['usersession'])){
echo $form
} else {
$doquery=mysql_query("select * from users where username='$username'");
echo mysql_error();
while($nt=mysql_fetch_array($doquery)){
echo "hello $nt[username]";
}
}
    ?>

is the query correct?
i wasn't too sure on it

[alexgeek]

okay, i don't get a blank page anymore but it doesn't change when the user logs in:

PHP: Select all

   <?php
$form = "<form action=\"/User/login.php\" method=\"post\">Username:<br><input type=\"text\" name=\"user\"><br>Password:<br> <input type=\"password\" name=\"pass\"><br> <p align=\"center\"><input type=\"submit\" action=\"submit\" name=\"login\" value=\"login\"> </p> </form><p>Haven't got an account? Register</p><p>Forgot your password?</p>";
    
    if (!isset($_SESSION['usersession'])){
echo $form;
} else {
$doquery=mysql_query("select * from users where username='$username'");
echo mysql_error();
while($nt=mysql_fetch_array($doquery)){
echo "hello $nt[username]";
}
}

    ?>

[Voodoochilli]

ok try this

on every page, at the top, put:
print_r ($_SESSION);
tell me what you get, if anything.

[Voodoochilli]

and also, try to make it more obvious what you are looking for, i.e

<?php
$form = "<form action=\"/User/login.php\" method=\"post\">Username:<br><input type=\"text\" name=\"user\"><br>Password:<br> <input type=\"password\" name=\"pass\"><br> <p align=\"center\"><input type=\"submit\" action=\"submit\" name=\"login\" value=\"login\"> </p> </form><p>Haven't got an account? Register</p><p>Forgot your password?</p>";

if (!isset($_SESSION['usersession'])){
echo $form;
echo "TEST 1";
} else {//IS logged in
$doquery=mysql_query("select * from users where username='$username'");
echo "TEST 2";
echo mysql_error() or die(mysql_error() );
while($nt=mysql_fetch_array($doquery)){
echo "hello $nt[username]";
}
}

?>

[alexgeek]

Array ( [usersession] => [count] => 593 )
count was a little test i did to check if sessions where working.
and i will try that other one now thanks

[alexgeek]

only test 1 appeared.
does that mean there's something wrong with the query?

[Voodoochilli]

Originally Posted by alexgeek

only test 1 appeared.
does that mean there's something wrong with the query?

it means the php interpreter isnt getting to that bit, meaning, your code is broken before that point. ie after TEST 1 and before TEST 2, so we know where the problem is!

[alexgeek]

yes and the part between is:

PHP: Select all

$doquery=mysql_query("select * from users where username='$username'"); 

[Voodoochilli]

try changing
$doquery=mysql_query("select * from users where username='$username'");
to
echo "test 3";
if that works then we know there a MYSQL error. Also don't you use a mysql link identifier, I mean my mysql quries look like:

mysql_query("select * from users where username='$username'", $dl );

[alexgeek]

i don't know what a link identifier does to be honest.
and umm changing it to echo test 3 made no difference :/

PHP: Select all

if (!isset($_SESSION['usersession'])){
echo $form;
echo "TEST 1";
} else {//IS logged in
echo "test 3";
echo "TEST 2";
echo mysql_error() or die(mysql_error() );
while($nt=mysql_fetch_array($doquery)){
echo "hello $nt[username]";
}
} 

also,
you know in this part:
Array ( [usersession] => [count] => 593 )
does that mean that usersession doesn't contain anything?
should't it say something like [usersession] = alex
?

[alexgeek]

ahh in the login script, i didn't assign the $username variable to anything.

[Voodoochilli]

I will have to check this tomorrow, its too late for me to think php right now (2 am) Promise I will have a think in the morning for you.

[alexgeek]

sorry to keep you up!
thank you!

[Voodoochilli]

morning

ok Array ( [usersession] => [count] => 593 ) means there is something stored in it. print_r() is very useful to know if an array contains anything.

putting that in:
echo "test 3";
echo "TEST 2";
was silly of me, must have been tired. you only need 1 echo.

can you echo the $username variable at the top to make sure it contains something ?

[Voodoochilli]

also shouldn't echo "hello $nt[username]";
be
echo "hello $nt['username']";

Does it even echo the hello part?

[alexgeek]

right i've changed the session to "loggedin"
adding the '' to the echo made a blank page, and i don't know why i have a blank page because my php.ini says to display errors. anyway this is the code i'm using: (still not sure if the query is right.)

PHP: Select all

<?php
  $form = "<form action=\"/User/login.php\" method=\"post\">Username:<br><input type=\"text\" name=\"user\"><br>Password:<br> <input type=\"password\" name=\"pass\"><br> <p align=\"center\"><input type=\"submit\" action=\"submit\" name=\"login\" value=\"login\"> </p> </form><p>Haven't got an account? <a href=\"\User\/register.php\">Register</a></p><p>Forgot your password?</p>";
  
$username = $_SESSION['loggedin'];

if (!isset($_SESSION['loggedin'])){
echo $form;
} else {//IS logged in
$doquery = mysql_query("select * from users where username=$username");
echo mysql_error() or die(mysql_error() );
while($nt=mysql_fetch_array($doquery)){
echo "hello $nt['username']";
}
}

?>

logging in is working, but the "else" part has problems

[alexgeek]

right new one.
this is sort of working.
i think there's a problem with the "while" part though :/

PHP: Select all

 <?php
  $form = "<form action=\"/User/login.php\" method=\"post\">Username:<br><input type=\"text\" name=\"user\"><br>Password:<br> <input type=\"password\" name=\"pass\"><br> <p align=\"center\"><input type=\"submit\" action=\"submit\" name=\"login\" value=\"login\"> </p> </form><p>Haven't got an account? <a href=\"\User\/register.php\">Register</a></p><p>Forgot your password?</p>";
  
$username = $_SESSION['loggedin'];

if (!isset($_SESSION['loggedin'])){
echo $form;
} else {//IS logged in
$thequery="select * from users WHERE username='$username'";
$doquery=mysql_query($thequery);
echo mysql_error() or die(mysql_error() );
while($nt=mysql_fetch_array($doquery)){
echo "hello $nt[username]";
}
}

?>

[alexgeek]

got it working

PHP: Select all

  <?php

//Database Information

$dbhost = "localhost";
$dbname = "web";
$dbuser = "alex";
$dbpass = "pass";

//Connect to database

mysql_connect ( $dbhost, $dbuser, $dbpass)or die("Could not connect: ".mysql_error());
mysql_select_db($dbname) or die(mysql_error());

  $form = "<form action=\"/User/login.php\" method=\"post\">Username:<br><input type=\"text\" name=\"user\"><br>Password:<br> <input type=\"password\" name=\"pass\"><br> <p align=\"center\"><input type=\"submit\" action=\"submit\" name=\"login\" value=\"login\"> </p> </form><p>Haven't got an account? <a href=\"\User\/register.php\">Register</a></p><p>Forgot your password?</p>";
  
$username = $_SESSION['loggedin'];

if (!isset($_SESSION['loggedin'])){
echo $form;
} else {
$query = "SELECT * FROM users WHERE username='alexgeek' ";

$result = mysql_query($query) or die(mysql_error());


// Print out the contents of each row into a table 
while($row = mysql_fetch_array($result)){
    echo $row['username']. " - ". $row['score'];
    echo "<br />";
}
}
?>

[Voodoochilli]

$query = "SELECT * FROM users WHERE username='alexgeek' ";

$result = mysql_query($query) or die(mysql_error());


// Print out the contents of each row into a table
while($row = mysql_fetch_array($result)){
echo $row['username']. " - ". $row['score'];
echo "<br />";

ha! you did the 2 things I was going to suggest! Put the or die in the query, not after, then add '' to the var name!

[Voodoochilli]

glad its sorted (again!)