php error

acrikey · #1 Jul 20th, 2007, 18:00

Getting an error, could someone check my code please

main page that you input data

<head>
<title>Email Form</title>
</head>

<body>
<Form action="sendmail.php" method post
<p><strong>Name:</strong><br /> <input type="text" size="25" name="name" /></p>
<p><strong>E-mail Address:</strong><br />
<input type="text" size="25" name="email" /></p>
<p><strong>Message:</strong><br />
<textarea name="message" cols="30" rows="5"></textarea></p>
<p><input type="submit" value="send" /></p>
</Form>
</body>
</html>

and then the action page

Code: Select all

<head>
<title>Sending Mail</title>
</head>

<body>
<?php
echo "<p>Thank you, <b>"$_POST["name"]."</b>, for your message!</p>";
echo "<p>Your e-mail address is: <b>".$_POST["email"]."</b>.</p>";
echo "<p>Your message was: <br>"";
//start building the mail string
$msg = "Name":        ".$_POST["name"]."\n";
$msg .= "E-Mail:    ".$_POST["email"]."\n";
$msg .= "Message    ".$_POST["message"]."\n";
//set up the mail
$recipient = "name@domainname.com";
Ssubject = "Message from website";
$mailheaders = "From: My Website <name@domainname.com> \n";
$mailheaders .= "Reply-To: ".$_POST["email"];
//send the email
mail($recipient, $subject, $msg, $mailheaders);
?>
</body>
</html>

thank you

acrikey · #2 Jul 20th, 2007, 18:02

Here it is live online

http://www.lightex.co.uk/testfolder/feedback.html

balaclave · #3 Jul 20th, 2007, 18:15

The HTML at the start of the form line should be:

HTML: Select all

<form method = "post" action="sendmail.php">

In your PHP code, you say "Your message was:" but then never echo() $msg, so the message won't be displayed.
Also, remember to filter HTML characters from your input before putting the code live.
Use htmlspecialchars().

This code might pose a problem:

PHP: Select all


echo "<p>Your message was: <br>"";

Due to the two quotes at the end, you would be terminating the string to echo then opening a new one without closing.
Just remove one to fix the problem.
Also, in the first line of the PHP you missed out a concatenation "dot", and you had an extra quote after "Name", and a few other bits and bobs.

So some code for the PHP part might be:

PHP: Select all


<head>
<title>Sending Mail</title>
</head>

<body>
<?php
echo "<p>Thank you, <b>" . htmlspecialchars($_POST['name']) . "</b>, for your message!</p>";
echo "<p>Your e-mail address is: <b>" . htmlspecialchars($_POST['email']) . "</b>.</p>";
echo "<p>Your message was: <br>";
//start building the mail string
$msg = "Name:        " . $_POST['name'] . "\n";
$msg .= "E-Mail:    " . $_POST['email'] . "\n";
$msg .= "Message    " . $_POST['message'] . "\n";
//set up the mail
$message = $_POST['message'];
echo (htmlspecialchars($message));
$recipient = "name@domainname.com";
$subject = "Message from website";
$mailheaders = "From: My Website <name@domainname.com> \n";
$mailheaders .= "Reply-To: " . $_POST['email'];
//send the email
mail($recipient, $subject, $msg, $mailheaders);
?>
</body>
</html>

But apart from that, sendmail.php gives me a 404 error.
Are you sure it has been uploaded to your server?

acrikey · #4 Jul 20th, 2007, 18:53

Sorry forgot to upload that part, but still getting nothing

http://www.lightex.co.uk/testfolder/sendmail.php

balaclave · #5 Jul 20th, 2007, 19:22

Can you post exactly what code is in sendmail.php?

acrikey · #6 Jul 20th, 2007, 19:27

Quote:

<?php
echo "Thank you, " . htmlspecialchars($_POST["name"]) . ", for your message!";
echo "Your e-mail address is: " . htmlspecialchars($_POST["email"]) . ".";
echo "Your message was: ";
//start building the mail string
$msg = "Name: " . $_POST["name"] . "\n";
$msg .= "E-Mail: " . $_POST["email"] . "\n";
$msg .= "Message " . $_POST["message"] . "\n";
//set up the mail
echo ("htmlspecialchars($msg)");
$recipient = "alex@acrikey.com";
Ssubject = "Message from website";
$mailheaders = "From: My Website <alex@acrikey.com> \n";
$mailheaders .= "Reply-To: " . $_POST["email"];
//send the email
mail($recipient, $subject, $msg, $mailheaders);
?>

c010depunkk · #7 Jul 20th, 2007, 19:29

There are still some code errors. Try this:

HTML code:

Code: Select all

<head>
<title>Email Form</title>
</head>

<body>
<form action="sendmail.php" method="post">
<p><strong>Name:</strong><br /> <input type="text" size="25" name="name" /></p>
<p><strong>E-mail Address:</strong><br />
<input type="text" size="25" name="email" /></p>
<p><strong>Message:</strong><br />
<textarea name="message" cols="30" rows="5"></textarea></p>
<p><input type="submit" value="send" action="submit" /></p>
</form>
</body>
</html>

and PHP code:

PHP: Select all


<head>
<title>Sending Mail</title>
</head>

<body>
<?php
//start building the mail string
$msg = "Name:        " . $_POST["name"] . "\n";
$msg .= "E-Mail:    " . $_POST["email"] . "\n";
$msg .= "Message    " . $_POST["message"] . "\n";
// output to the user
echo("<p>Thank you, <b>" . htmlspecialchars($_POST["name"]) . "</b>, for your message!</p>");
echo("<p>Your e-mail address is: <b>" . htmlspecialchars($_POST["email"]) . "</b>.</p>");
echo("<p>Your message was: ".htmlspecialchars($msg)."<br>");
//set up the mail
$recipient = "name@domainname.com";
$subject = "Message from website";
$mailheaders = "From: My Website <name@domainname.com> \n";
$mailheaders .= "Reply-To: " . $_POST["email"];
//send the email
mail($recipient, $subject, $msg, $mailheaders);
?>
</body>
</html>

balaclave · #8 Jul 20th, 2007, 19:57

Thought I'd make another reply.

My PHP is now tested and working (quotation marks around htmlspecialchars() were causing php to output that as text, and an S had somehow sneaked in and replaced a $ symbol

).
At the moment, my original code and c010depunkk's will output $msg which is the email message - I think it would be better just to output $_POST['message'] at the place where it says "Your message was:".

This defintely works:

PHP: Select all


<head>
<title>Sending Mail</title>
</head>

<body>
<?php
echo "<p>Thank you, <b>" . htmlspecialchars($_POST['name']) . "</b>, for your message!</p>";
echo "<p>Your e-mail address is: <b>" . htmlspecialchars($_POST['email']) . "</b>.</p>";
echo "<p>Your message was: <br>";
//start building the mail string
$msg = "Name:        " . $_POST['name'] . "\n";
$msg .= "E-Mail:    " . $_POST['email'] . "\n";
$msg .= "Message    " . $_POST['message'] . "\n";
//set up the mail
$message = $_POST['message'];
echo (htmlspecialchars($message));
$recipient = "name@domainname.com";
$subject = "Message from website";
$mailheaders = "From: My Website <name@domainname.com> \n";
$mailheaders .= "Reply-To: " . $_POST['email'];
//send the email
mail($recipient, $subject, $msg, $mailheaders);
?>
</body>
</html>

acrikey · #9 Jul 20th, 2007, 20:24

it's just sitting on sendmail.php, not doing anything

balaclave · #10 Jul 20th, 2007, 21:46

Re-upload a working version and try again?
Does your host support PHP?
It works here.

acrikey · #11 Jul 20th, 2007, 23:08

thank you sorted, it's working fine thank you

balaclave · #12 Jul 20th, 2007, 23:18

Quote:

thank you sorted, it's working fine thank you

Great!

Is there anything else you would like to know to tweak your form, or are you happy with it now?

pa007 · #13 Jul 20th, 2007, 23:27

Hey balaclave where you learn all this php goodliness. I'm struggling with it all to be honest.

Pete.

acrikey · #14 Jul 21st, 2007, 00:27

Not that I can think of, but I'm bookmarking you, your very useful!!!!
Thanks again mate.
Still learning php so thought I was doing well till it did not work!

balaclave · #15 Jul 21st, 2007, 18:05

Quote:

Hey balaclave where you learn all this php goodliness.

Nowhere really.
I've not had any tuition but I'm good at maths and problem solving which, I am certain, helps.

php.net is probably the most useful website (since it contains the php manual).
For everything else there's Google.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
[SOLVED] Getting the "Microsoft JET Database Engine error '80040e14'" error.	VegaLA	Classic ASP	3	Jan 26th, 2008 00:12
Keep getting error message Microsoft VBScript runtime error '800a01a8'	cpando1974	Classic ASP	2	Aug 7th, 2007 12:00
Error 500 - Internal server error	JasonStanley	PHP Forum	3	Apr 23rd, 2007 17:56

		Webforumz.com > Main Forums > Program Your Website > PHP Forum
php error