error in unsubscribe.php script

[csun]

i have this code below unsubscribe php script in which it occurs an error wen i run the script, please could any one help me solve this script.. thanks

error: Fatal error: Call to undefined function: delete_mail() in /home/simply22/public_html/test/mailing/unsubscribe.php on line 14

Code: Select all

<?
    require('inc/config.php');

    if ($_SERVER['REQUEST_METHOD'] == "POST") {

        delete_mail("POST");
    }
    if ($_SERVER['REQUEST_METHOD'] == "GET") {
        if ($_GET['email'] == "") {
           include('inc/form2.php');
        } else {
           delete_mail("GET"); ---> in this line coz the error
        }
    }

?>

[grahame]

There is no delete_mail function in PHP, but you can define your own - either via the include file that's called in at the top of your script, or within your own script if you prefer.

[Blake121]

I think your looking for the unset() function. e.g.

PHP: Select all

<?
    require('inc/config.php');

    if ($_SERVER['REQUEST_METHOD'] == "POST") {

        unset($_POST);
    }
    if ($_SERVER['REQUEST_METHOD'] == "GET") {
        if ($_GET['email'] == "") {
           include('inc/form2.php');
        } else {
           unset($_GET);
        }
    }

?>

[csun]

i use the unset function but it doesn't work here is the other code below for the function delete_mail()

Code: Select all

<?
function delete_mail() {

    $email = $_POST['email'];

    if ($email == "") {
       $email = $_GET['email'];
    }

    $sql2="select * from mail where email='$email'";
    $result2=mysql_query($sql2) or die("select  fails");
    $no=mysql_num_rows($result2);

    if ($no==0) {
       echo "Your email was not found in the list: " . LISTNAME;
    } else {
       echo "Your email was unsubscribed from the list: " . LISTNAME;
    }

    $sql2="delete from mail where email='$email'";
    $result2=mysql_query($sql2) or die("unsubscribe failed, please try again");

    }
}

?>

[balaclave]

I think I've seen the problem.
You called a function, specifying text as a parameter.
Also, in your function you failed make reference to the parameter, so nothing would have been passed to the function to delete.

PHP: Select all

<?php

    require('inc/config.php');



    if ($_SERVER['REQUEST_METHOD'] == "POST") {



        delete_mail("$_POST[email]");

// Before it was just "POST"



    }

    if ($_SERVER['REQUEST_METHOD'] == "GET") {

        if ($_GET['email'] == "") {

           include('inc/form2.php');

        } else {

           delete_mail("$_GET[email]");

// before it was just GET

        }

    }



?>

Notice that you are sending parameters, so we need to accommodate them in the function.

i.e.

PHP: Select all

<?php

function delete_mail($email) {



      $sql2="select * from mail where email='$email'";

    $result2=mysql_query($sql2) or die("select  fails");

    $no=mysql_num_rows($result2);



    if ($no==0) {

       echo "Your email was not found in the list: " . LISTNAME;

    } else {



    $sql2="DELETE * FROM mail WHERE email='$email'";

    $result2 = mysql_query($sql2) or die("unsubscribe failed, please try again");



       echo "Your email was unsubscribed from the list: " . LISTNAME;



    }



   

}



?>

Hopefully that should work.

[dnhdevelopment]

Balaclave has the better practice on handling this situation.. instead of calling the value from the $_POST pass it right to the function. But just for CSUN's information that since his function doesn't take any parameters (originally) from the way it looks he could have solved the problem by passing nothing.




delete_mail();

<?
function delete_mail() {

$email = $_POST['email']; //gets the value


################################################## #############
# if ($email == "") { #
# $email = $_GET['email']; //is this line even needed? #
# if you don't get a value from the $_POST (since i would #
# assume you are posting this form, should this be an error #
# Handler instead?) just a thought, #
# #
# If ($_POST['email'] != "" || NULL){ #
# do something #
# } #
# else { #
# Display error. #
# } #
# #
################################################## #############


$sql2="select * from mail where email='$email'";
$result2=mysql_query($sql2) or die("select fails");
$no=mysql_num_rows($result2);

if ($no==0) {
echo "Your email was not found in the list: " . LISTNAME;
} else {
echo "Your email was unsubscribed from the list: " . LISTNAME;
}

$sql2="delete from mail where email='$email'";
$result2=mysql_query($sql2) or die("unsubscribe failed, please try again");

}
}

?>


However as i said Bala has the right idea about the proper format, though i am unsure if just passing "$_POST" and "$_GET" will do what you want, your going to want to pass the email address it self. So you would probably rather pass: delete_mail($_POST['email']); i could be wrong.

[balaclave]

So you would probably rather pass: delete_mail($_POST['email']); i could be wrong.

Yeh, you're right.
Except you can't have apostrophes in the $_GET or $_POST so you just have to use delete_mail($_GET[email]);

So some working code would be:

PHP: Select all

   <?php
    require('inc/config.php');

    if ($_SERVER['REQUEST_METHOD'] == "POST") {

        delete_mail("$_POST[email]");
// Before it was just "POST"

    }
    if ($_SERVER['REQUEST_METHOD'] == "GET") {
        if ($_GET['email'] == "") {
           include('inc/form2.php');
        } else {
           delete_mail("$_GET[email]");
// before it was just GET
        }
    }

?>

And the function:

PHP: Select all

   <?php
function delete_mail($email) {

      $sql2="select * from mail where email='$email'";
    $result2=mysql_query($sql2) or die("select  fails");
    $no=mysql_num_rows($result2);

    if ($no==0) {
       echo "Your email was not found in the list: " . LISTNAME;
    } 
    else {

    $sql2="DELETE * FROM mail WHERE email='$email'";
    $result2=mysql_query($sql2) or die("unsubscribe failed, please try again");

       echo "Your email was unsubscribed from the list: " . LISTNAME;
    }


}

?>

Somehow an extraneous } got in my function code so it's now removed.

[dnhdevelopment]

good catch. Bad habit of mine. so used to doing a

Code: Select all

document.getElementById('****');

and unless we hear otherwise from the original poster.

*ding* Next!