e-mail screen problem

[kool77]

Hi
I have this question:

The email screen will display the old email address and ask for the new email address. Once a student enters the new email address, it will automatically send an email to that address and take the student to a new screen that says that the email has been sent and display a link to go back to the main panel.

I did it like this but it doesn't seem to work

Code: Select all

<?php
session_start();
$stid=$_SESSION['sid'];
if(!isset($stid)){
include("anauthorized.html");
exit();
}
?>
//Some html codes here I deleted just to post PHP codes
 
    include('DB_connectscript.php');
    if(isset($_POST['submit']))
    {
     if($form_errors = check())
     {
      show_form($form_errors);
     }
     else
     {
      process();
     }
    }
    else
    {
     show_form();
    }
 
   function show_form($errors='')
   {
    print "<br/>";
    print "<br/>";
    print "<br/>";
    print "<form method='POST' action='".$_SERVER['PHP_SELF']."'>";
    print "<h3 align = 'center'>Please fill your data in the following fields:</h1><table align = 'center' border='0' dir='ltr'>";
 
    print "<tr>";
    print "<td colspan='2'>";
    if ($errors) {
     print "<font color='#FF0000'>";
     print "<ul><li>";
     print implode("</li><li>",$errors);
     print "</li></ul>";
    }
    print "</tr>";
 
    print "<tr>";
    print "<td><font size='2'> Enter your new E-mail address </font></td><td><input type='text' name='mail'></td>";
    print "</tr>";
    print "<tr>";
    print "<td colspan='2'>";
    print "<p align='center'>";
    print "<input type='submit' value='Submit' name='submit' dir='ltr'>";
    print "</tr>";
    print "</table>";
    print "</form>";
    print "<br/>";
    print "<br/>";
    print "<br/>";
   }
   function check()
   {
    global $stid;
    $errors = array();
    if (!$_POST['mail'])
    {
 
     $errors[] ='You did not fill in a required field';
     return $errors;
    }
    if(!eregi("^[_a-z0-9-]+(.[_a-z0-9-]+)*@[a-z0-9-]+(.[a-z0-9-]+)*(.[a-z]{2,3})$", $_POST['mail'])) 
    {
     $errors[] ='Invalid E-mail Address.';
     return $errors;
    } 
   } 
   function process()
   {
    global $stid;
    $mail = $_POST['mail'];
    $update = "UPDATE STUDENT SET EMAIL = '$mail' WHERE SID = '$stid'";
    $result= mysql_query($update);
    if(!$result)
    {
     print "Update ERROR:". mysql_error();
     exit();
    }
    else
    {
     echo '<META HTTP-EQUIV="Refresh" CONTENT="3;URL=userpage.php">';
    }
   }
   ?>

Is that correct??
thank you

[Accurax]

might be going blind here .... but where is your mail() statement?

Also, I like to sepearate my forms from the processing ... that way you could use the header function at the bottom, as its very unlikley you'd have any output on a pure processing page.

[masonbarge]

Originally Posted by Accurax

Also, I like to sepearate my forms from the processing ... that way you could use the header function at the bottom, as its very unlikley you'd have any output on a pure processing page.

LOL, I've gotten to just about the opposite point -- I like include everything on one page if it doesn't hurt the initial load time. It may be an eccentricity, I don't know -- it certainly takes more exacting organization as you have, by definition, at least one more layer of "if" statements.

You can use conditional headers fine, you just have to have common formatting modularized.

That is, the biggest downside for including form handlers and forms on one page is, that if you do very much with the http headers (including session and cookie work), it sometimes deprives you of the ability to put common html in one place. Eventually the need to send header information before calling the http response may require you to repeat a section of html inside different conditional branches.

This is, I think, solved fully by putting the repetitive matter in a class or include. I hope I am correct that php won't load the include unless and until it hits a valid conditional trigger.

Well maybe I'd better ask this as a question. I am thinking that in example #1 the html "Tons of nonsense" is going to be loaded into memory twice, whereas in example #2 it will be loaded only once (for a single http request):
#1

PHP: Select all

<?php
if($x) { ?>
<div> . . . Tons of nonsense . . . </div>
<div> . . . Tons of drivel . . . </div>
<?php } else { ?>
<div> . . . Tons of nonsense . . . </div>
<div> . . . Tons of different drivel . . . </div>
<?php } ?>

#2

PHP: Select all

<?php
if($x) { ?>
include('./tons_of_nonsense.inc');
<div> . . . Tons of drivel . . . </div>
<?php } else { ?>
include('./tons_of_nonsense.inc');
 <div> . . . Tons of different drivel . . . </div>
<?php } ?>

But one thing anyone would have to agree on -- it's essential to "see" the processing as a separate entity.

[kool77]

I forgot to add e-mail function lol I will add it right now!

I think using include makes the script looks better but I don't like to do that mostly.

thank you for replaying my friends