Poll

[robukni]

Hi i am trying to create a voting system but for some reason the code i am using wont work

code:

PHP: Select all

    <?php
    
    
    mysql_connect("localhost", "", "") or die(mysql_error());
    mysql_select_db("") or die(mysql_error());

    //Name of our cookie
    $cookie = "Voted";

    //A function to display our results - this refrences vote_pie.php which we will also make
    function pie ()
    {
    $data = mysql_query("SELECT * FROM votes")
    or die(mysql_error());
    $result = mysql_fetch_array( $data );
    $total = $result[first] + $result[sec] + $result[third];
    $one = round (360 * $result[first] / $total);
    $two = round (360 * $result[sec] / $total);
    $per1 = round ($result[first] / $total * 100);
    $per2 = round ($result[sec] / $total * 100);
    $per3 = round ($result[third] / $total * 100);
    echo "<img src=vote_pie.php?one=".$one."&two=".$two."><br>";
    Echo "<font color=ff0000>FIRST</font> = $result[first] votes, $per1 %<br>
    <font color=0000ff>SECOND </font> = $result[sec] votes, $per2 %<br>
    <font color=00ff00>THIRD </font> = $result[third] votes, $per3 %<br>";
    }
    //This runs if it is in voted mode
if ( $mode=="voted")
{

//makes sure they haven't already voted
if(isset($_COOKIE[$cookie]))
{
Echo "Sorry You have already voted this month<br>";
}

//sets a cookie
else
{
$month = 2592000 + time();
setcookie(Voted, Voted, $month);

// adds their vote to the database
switch ($vote)
{
case 1:
mysql_query ("UPDATE votes SET first = first+1");
break;
case 2:
mysql_query ("UPDATE votes SET sec = sec+1");
break;
case 3:
mysql_query ("UPDATE votes SET third = third+1");
}

//displays the poll results
pie ();
}
}
//if they are not voting, this displays the results if they have already voted
if(isset($_COOKIE[$cookie]))
{
pie ();
}

// or if they have not voted yet, they get the voting box
else
{
if(!$mode=='voted')
{
?>
<form action = "<?php echo $_SERVER[&#8217;PHP_SELF’]; ?>" method = "GET">
<select name="vote"> <option value="1">Option 1</option>
<option value="2">Option 2</option> <option value="3">Option 3</option>
</select>
<input type=hidden name=mode value=voted>
<input type=submit>
</form>
<?
}
}
?>
?>

I have created the DB in mysql and all the field names are correct.

Anyone any ideas of what could be wrong, or is there an easier way to create a poll?


Thanks
Robert

[masonbarge]

I hate to say this, but I have never been able to take a bit of packaged code and make it work. I tried a few times early on but I always ended up rewriting it so much that I might have been better off starting from scratch.

I just don't see this scheme. I'm sorry, I really am trying to say something helpful, but it's so full of questions I just can't take it on. My advice would be to figure out the methodology and recode it from scratch, testing step by step.

I immediately noticed this:

PHP: Select all

echo "<img src=vote_pie.php?one=".$one."&two=".$two."><br>"; 

A small thing, but there is no sense in concatenating the variables.

PHP: Select all

echo "<img src=vote_pie.php?one=$one&two=$two><br>"; 

Also, If this is XHTML you might need to code the ampersand.

Does the table have columns named 'first', 'sec', and 'third', or are these supposed to be rows? Okay, I see, you have a single row with these three field names and increase the proper field by one to reflect each vote.

Since you are using an associative array, don't you need to put the associative key name in single quotes? I think this is mandatory, but I always use numerical keys so I've lost touch, LOL. Also, I like to get my resources into variable values ASAP. That might be your problem.

I'm sorry this post is so wordy and I'm not sure what isn't working, but if it helps, I'd handle the query return like so (using the correct key number if you use a different query such as "SELECT *"):

PHP: Select all

$query = "SELECT first, sec, third FROM votes";
$result = mysql_query($query);
$data = mysql_fetch_row($result);
$one = $data[0];
$two = $data[1];
$three = $data[2]; 

Now, echo each of the variables to see if you are getting the right value. If you are, remove the echo and you can proceed knowing you have correct variables. If not, you know that the query return is incorrect.