Help using document.getElementById

[jonnymorris]

Hi!

I have this piece of javascript which enables some nifty image and text swapping, however I would like it to also include a link around the main image tag but can't get it to work, can anyone tell me what I have to add? I have tried adding a link id and another line to my javascript code but it does not add the link.

Here's the script:

Code: Select all

<script type="text/javascript">
        function replaceMainImage(NEWTEXT, NEWIMAGE) {
             document.getElementById("thecontainer").innerHTML = '<img name="mainimage" src="'+NEWIMAGE+'" alt="Main image">';
            document.getElementById("description").innerHTML = ''+NEWTEXT+'';    
        }
        
</script>

and here is where I use the script in my page:

Code: Select all

<div id="thecontainer">
      
                  <img name="mainimage" src="images/web_main_rennaissance.png" alt="Main image" />
          </div>

This is the thumb image part that, when clicked, replaces "mainimage" with the appropriate image:

Code: Select all

<a href="javascript:void(0);" title="Cow With Horns" onclick="replaceMainImage('Cow With Horny Horns', 'images/photo_main_cowhorns.png');">
                          <img border="0" width="97px" height="76px" 
                          alt="Photo - Cow With Horns" src="images/photo_cowhorns.png">
                      </a>

It was actually someone on these forums who helped me with the code (they wrote it, I used it and thanked them )

[LumberJake]

<script type="text/javascript">
function replaceMainImage(NEWTEXT, NEWIMAGE, link) {
document.getElementById("thecontainer").innerHTML = '<a href="'+ link +'"><img name="mainimage" src="'+NEWIMAGE+'" alt="Main image"></a?';
document.getElementById("description").innerHTML = ''+NEWTEXT+'';
}

</script>

<a href="javascript:void(0);" title="Cow With Horns" onclick="replaceMainImage('Cow With Horny Horns', 'images/photo_main_cowhorns.png', 'url_you_for_anchor');">
<img border="0" width="97px" height="76px"
alt="Photo - Cow With Horns" src="images/photo_cowhorns.png">
</a>

[LumberJake]

How the hell do you edit posts in this forum?

I think that is what you wanted.

Just replace 'url_you_for_anchor' (which is how it came out when i tried to type 'url_for_your_anchor'). Each call to the function without a url as an argument will give an invalid number of arguments error, so update all your previous calls to it.

[jonnymorris]

Originally Posted by LumberJake

How the hell do you edit posts in this forum?

I have a little button at the bottom of my posts called Edit, it is really faint though.

Originally Posted by LumberJake

I think that is what you wanted.

Yes! Thank you very very much! I feel so thick, it looks so obvious, duh! I really ought to be able to work this kind of thing out for myself.. oh well, that's what forums are for.