www.maxfield.co.nr

UUDDLRLRBA · #1 Jan 24th, 2008, 21:22

Hey everyone,

I submitted my site to my instructor to be graded. The goals were to create site using a two or three column layout, use css for the layout or just for the text, create a proper navigation and have it validate.

I just threw together some stuff for the content that I felt like putting up.

It includes a design and website portfolio, a tutorial for modifying a online poker client (Full Tilt Poker), a photogallery, streaming audio (which doesn't work currently since I reset my router and haven't made a new static IP, but it did work), a silly YouTube video I made, and an email submission forum.

So tell me where I could improve.

Thanks a bunch.

Jack Franklin · #2 Jan 24th, 2008, 21:27

Not bad, rather plain. First thing I would do is centre the entire site horizontally.

unitedcraig · #3 Jan 24th, 2008, 21:40

Yeh i agree with jack, not sure what it is but doesn't quite look right left aligned, would be an improvement centered.

Adding images or simply a logo in your headed would also brighten it up a little, looks a bit dark at the moment.

unitedcraig · #4 Jan 24th, 2008, 21:40

Well done on the valid code by the way, perhaps switch to strict?

UUDDLRLRBA · #5 Jan 25th, 2008, 05:34

Quote:

Originally Posted by jackfranklin

Not bad, rather plain. First thing I would do is centre the entire site horizontally.

I know what you're saying. I was wanting to align center it, but I wasn't to sure how to do it. I may take the time and change this.

I also originally had an image in a column on the right of each page but I got rid of it because they had little relevance.

The aesthetics were not planned out too well. I was always changing things half way through.

I'll comment more in the morning. (yawn)

Thanks for the responses btw.

minute44 · #6 Jan 25th, 2008, 09:25

Put all content inside a wrapper and then:

#wrapper {
position: relative;
margin: 0px auto 0px auto;
}

MikeHopley · #7 Jan 25th, 2008, 09:53

Quote:

Originally Posted by minute44

Put all content inside a wrapper and then:

#wrapper {
position: relative;
margin: 0px auto 0px auto;
}

Eh? Why the "position: relative"? And don't forget to specify a width:

Code: Select all

#wrapper {
width: 750px;              /* or 60em, or whatever */
margin: 0 auto;
}

minute44 · #8 Jan 25th, 2008, 10:05

alright, alright....

It's the left and right margins set to auto that's important.... everything else is variable.

UUDDLRLRBA · #9 Jan 25th, 2008, 13:48

I remember now why I didn't center it. I had already made the nav with css and if I changed it to center, the navigation would be misaligned.

I was probably using a different method to center it, (not sure what) but would the above method ensure my css nav remains aligned (in hover and selected state)?

Thanks again.

UUDDLRLRBA · #10 Jan 25th, 2008, 13:58

Quote:

Originally Posted by unitedcraig

Adding images or simply a logo in your headed would also brighten it up a little, looks a bit dark at the moment.

I was thinking of putting some kinda of backdrop behind the content and a the same for the left nav.

Quote:

Originally Posted by unitedcraig

Well done on the valid code by the way, perhaps switch to strict?

You mean switch the DOCTYPE to ...

HTML: Select all

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
"http://www.w3.org/TR/html4/strict.dtd">

...?

I don't understand the relevance of using different DOCTYPE?

If I use strict or loose, isn't it going to show up the same in all browsers?

minute44 · #11 Jan 25th, 2008, 14:08

A doctype is what tells the browser what it is reading. A strict doctype pretty much forces you to write correct code. Transitional allows a few "mistakes" such as certain attributes that aren't allowed in strict doctypes.

Read Mike Hopley's article on doctypes for more information...

UUDDLRLRBA · #12 Jan 25th, 2008, 15:04

Is there a benefit to changing the doctype to strict?

Edit: reading article

:P

Edit x2: Good article. So to summarize, using strict doctype is basically saying that your page is coded to a higher standard?

Since strict doesn't support target="_blank", and css can't handle this, should I just live with the one error, or change the pages with target="_XXX" to loose?

minute44 · #13 Jan 25th, 2008, 15:14

Yes, it encourages better use and promotion of web standards.

MikeHopley · #14 Jan 26th, 2008, 09:05

Quote:

Originally Posted by UUDDLRLRBA

Edit x2: Good article. So to summarize, using strict doctype is basically saying that your page is coded to a higher standard?

Since strict doesn't support target="_blank", and css can't handle this, should I just live with the one error, or change the pages with target="_XXX" to loose?

Using strict enforces some good coding habits. The main benefit is that your code will be much more efficient: smaller file sizes, and easier maintenance (because more logical). Your pages are also likely to be more accessible.

target="_blank" is deprecated for a reason: it's a bad behaviour. It takes control away from the user.

You might think that you're keeping them on your website, but really the new window obscures the existing window and disables their primary navigation method, the back button. So actually you're more likely to prevent users from returning to your site.

In any case, it's annoying to have new windows/tabs spawned without requesting it.

UUDDLRLRBA · #15 Jan 28th, 2008, 10:35

Good points. In this case, the _blank is for the free counter's and free domain's website. Once I get some space / domain of my own, I won't have to worry bout this I suppose.

Alright, next step is to get this puppy centered. Busy week ahead, but I'll hopefully have time.

UUDDLRLRBA · #16 Jan 31st, 2008, 22:43

Alright, the site has been centered and I changed the color scheme to something more bright.

The nav and logo are a bit more informal now, but I think it's a nice change.

Any other suggestions?

minute44 · #17 Feb 1st, 2008, 07:43

Looks better but I don't like the hover effect on your navigation. Also, lose the hit counter. No one gives a toss.

UUDDLRLRBA · #18 Feb 1st, 2008, 10:32

Quote:

Originally Posted by minute44

Looks better but I don't like the hover effect on your navigation. Also, lose the hit counter. No one gives a toss.

Any suggestions for the hover effect?

I'll X the counter.

Also, I think I'll change the grey bg to something more grey/blue.

I'm thinking I should have some type of imagery in the header behind the logo.

		Webforumz.com > Main Forums > Design Your Website > Free Web Site Critique
www.maxfield.co.nr