Cleaning code...

[courtjester]

ok, this is what I have .

Code: Select all

<%
Dim moneyLeft
Dim totPrice
Dim WeapID

totPrice = Request.Form("Price")
WeapID = Request.Form("WeapID")

Set connectionToDatabase=Server.CreateObject("ADODB.Connection")
connectionToDatabase.ConnectionTimeout=60
connectionToDatabase.Open  "Provider=Microsoft.Jet.OLEDB.4.0;Data Source=MyDatabase"

Set recordSet=Server.CreateObject("ADODB.Recordset")
recordSet.Open "SELECT * FROM Setup WHERE Username='" & ID &  "'",connectionToDatabase,1,2

moneyLeft = recordSet("Gill") - totPrice

If recordSet("Gill") >= totPrice THEN
 If recordSet("Weapon") <> WeapID THEN
recordSet("Gill") = moneyLeft
recordSet("Weapon") = WeapID
recordSet("Attack") = recordSet("Attack") + 3
recordSet.Update
Response.Write(recordSet("Gill"))

Else 
If recordSet("Gill") < totPrice THEN
Response.Write("Im sorry, you don't have enough money")
Else 
If recordSet("Weapon") <> "" THEN
Response.Write("You currently have ")
Response.Write(recordSet("Weapon"))
Response.Write(" equipped")
Response.Write("
")
Else Response.Write("")
End If

If recordSet("Item1") = "1" THEN
recordSet("Item1") = WeapID
recordSet("Gill") = moneyLeft
recordSet.Update
Response.Write(WeapID)
Response.Write(" was stored in your Items")
Else 
If recordSet("Item2") = "1" THEN
recordSet("Item2") = WeapID
recordSet("Gill") = moneyLeft
recordSet.Update
Response.Write(WeapID)
Response.Write(" was stored in your Items")
Else 
If recordSet("Item3") = "1" THEN
recordSet("Item3") = WeapID
recordSet("Gill") = moneyLeft
recordSet.Update
Response.Write(WeapID)
Response.Write(" was stored in your Items")
Else 
If recordSet("Item4") = "1" THEN
recordSet("Item4") = WeapID
recordSet("Gill") = moneyLeft
recordSet.Update
Response.Write(WeapID)
Response.Write(" was stored in your Items")
Else 
If recordSet("Item5") = "1" THEN
recordSet("Item5") = WeapID
recordSet("Gill") = moneyLeft
recordSet.Update
Response.Write(WeapID)
Response.Write(" was stored in your Items")
Else 
If recordSet("Item6") = "1" THEN
recordSet("Item6") = WeapID
recordSet("Gill") = moneyLeft
recordSet.Update
Response.Write(WeapID)
Response.Write(" was stored in your Items")
Else 
If recordSet("Item7") = "1" THEN
recordSet("Item7") = WeapID
recordSet("Gill") = moneyLeft
recordSet.Update
Response.Write(WeapID)
Response.Write(" was stored in your Items")
Else 
If recordSet("Item8") = "1" THEN
recordSet("Item8") = WeapID
recordSet("Gill") = moneyLeft
recordSet.Update
Response.Write(WeapID)
Response.Write(" was stored in your Items")
Else 
If recordSet("Item9") = "1" THEN
recordSet("Item9") = WeapID
recordSet("Gill") = moneyLeft
recordSet.Update
Response.Write(WeapID)
Response.Write(" was stored in your Items")
Else 
If recordSet("Item10") = "1" THEN
recordSet("Item10") = WeapID
recordSet("Gill") = moneyLeft
recordSet.Update
Response.Write(WeapID)
Response.Write(" was stored in your Items")
End If
End If
End If
End If
End If
End If
End If
End If
End If
End If
End If
End If
End If
connectionToDatabase.close
Set connectionToDatabase=Nothing
%>

Just wondering if there is an easier way of doing the same thing. This is the only way I personally know how. Thanks.

[Webforumz Staff]

I would at least trim it down to this, though I'm not sure if the If statements are supposed to be exclusive - if so you'd want to put a . I never use the .update method of recordsets personally. I use SQL UPDATE queries instead.

Code: Select all

<%
Dim moneyLeft
Dim totPrice
Dim WeapID

totPrice = Request.Form("Price")
WeapID = Request.Form("WeapID")

Set con=Server.CreateObject("ADODB.Connection")
con.Open  "Provider=Microsoft.Jet.OLEDB.4.0;Data Source=MyDatabase"

set rs = con.execute("SELECT * FROM Setup WHERE Username='" & ID &  "'",,1)

moneyLeft = rs("Gill") - totPrice

If rs("Gill") >= totPrice THEN
  If rs("Weapon") <> WeapID THEN
    rs("Gill") = moneyLeft
    rs("Weapon") = WeapID
    rs("Attack") = rs("Attack") + 3
    rs.Update
    Response.Write(rs("Gill"))
  Else 
    If rs("Gill") < totPrice THEN
      Response.Write("Im sorry, you don't have enough money")
    Else 
      If rs("Weapon") <> "" THEN
        Response.Write("You currently have ")
        Response.Write(rs("Weapon"))
        Response.Write(" equipped")
        Response.Write("
")
        Else Response.Write("")
      End If
      
      bstored = false
      for i = 1 to 10
        If rs("Item" & i) = "1" and bstored=false THEN
          rs("Item" & i) = WeapID
          rs("Gill") = moneyLeft
          rs.Update
          Response.Write(WeapID)
          Response.Write(" was stored in your Items")
          bstored = true
        end if
      next
    End If
  End If
End If

con.close
Set con=Nothing
%>

[courtjester]

cool, I like the way you did that. I didn't think about doing it that way. It's still got about 10-15 more checks to do but this is the fuondation for my building, the rest I will figure out. I appreciate the help. Also, I noticed that you used rs and con. are these just to save you time or do they actually work? I would love to find out for myself, but my internet connection is down and I am having to use another computer. Thanks again for the help.

[Webforumz Staff]

No problem. Coding style varies from person to person.

rs and con are to save time and simplify the code. If you're not using Option Explicit and you use long variable names you're going to end up with typos in your variables, which can be wicked-hard to catch.

You might also consider making a function to do a check and calling it when you need to, or using SELECT CASE instead of lots of IF THEN statements.