Help on ASP procedure with VBScript

[malambing57]

I am new to ASP and been bugged down with this problem.

<font color="red">Below is a portion of my code and it runs perfectly:
Now when I change the value of formCategory it will call the function CheckRequiredText() and that is where I encounter problem</font id="red">

<%
varStaffName=Request.Cookies("varStaffName")
varDescription=Request.Cookies("varModuleDescripti on")
formDateFrom=Request.Cookies("varFormDatefrom")
formDateTo=Request.Cookies("varFormDateTo")
strSQL= " SELECT ModuleCode, ProgressComponentCode, ProgressComponentDesciption, ProgressComponentWeight"
strSQL= strSQL + " FROM dbo.ProgressReportComponent WHERE ModuleCode = " & varModulelD
strSQL= strSQL + " ORDER BY ProgressComponentDesciption "
'response.write(strSQL)
Set Re2 = conn.Execute(strSQL)
%>

<select name="formCategory" size="1" style="width:200;COLOR:#669966;" onChange="CheckRequiredText() ">
<%
strSQL3= " SELECT ProgressReportCommentsTypeCode, ProgressReportCommentsTypeDescription"
strSQL3= strSQL3 + " FROM dbo.ProgressReportCommentType WHERE ModuleCode = " & varModulelD
Set Re3 = conn.Execute(strSQL3)
do until Re3.EOF
response.write "<option value= " & Re3("ProgressReportCommentsTypeCode") & "> " & Re3("ProgressReportCommentsTypeDescription") & "</option>"
Re3.MoveNext
loop
Re3.close
Set Re3 = Nothing
%>
</select>


<font color="red">This is my CheckRequiredText() function. Everything is working on my function except when it connects to the database. That is when I get the error message "Error 424 Object Required" I can't figure out why my connection string is not working.</font id="red">

<SCRIPT LANGUAGE = "VBScript">
<!--
Private Function CheckRequiredText()

MsgBox "The " & Form.formCategory.options(Form.formCategory.select edIndex).value & " was the selected code."
varTypeCode= Form.formCategory.options(Form.formCategory.select edIndex).value
strSQL4=" SELECT ProgressReportCommentCode, ProgressReportCommentTypeCode, ProgressReportCommentDescription"
StrSQL4=strSQL4 + " FROM dbo.ProgressReportComment WHERE ProgressReportCommentTypeCode = " & varTypeCode
On Error Resume Next
MsgBox StrSQL4
Set Re4 = conn.Execute(strSQL4)

MsgBox "Error # " & CStr(Err.Number) & " " & Err.Description

End Function

----------------------------
<font color="red">This is the value of my conn</font id="red">
Set conn = Server.CreateObjectADODB.Connection)
conn.ConnectionTimeout = 30
conn.CommandTimeout = 30
conn.Open (Provider=SQLOLEDB;UID=ourUserID;Password=ourPassw ord;Initial Catalog=ourCatalog;Data Source=ourdatabasename and location)


Can someone help me figure out the solution to my problem.

[D3mon]

is varTypeCode an integer or string?

[malambing57]

Hi
Thanks for replying
I varTypeCode is an integer as it was derived from the index value of a SELECT field.

Terry

<blockquote id="quote"><font size="1" face="geneva, verdana, arial" id="quote">quote:<hr height="1" noshade id="quote">Originally posted by D3mon

is varTypeCode an integer or string?
<hr height="1" noshade id="quote"></blockquote id="quote"></font id="quote">

[D3mon]

<s>OK, did you define Re4 as a recordset?</s>
There's your problem, you appear to be trying to access your database from client-side script. While this may be possible it would mean revealing your DB connection details in the client-side code - a potentially fatal mistake.

[Rob]

this code:-

Code: Select all

Set conn = Server.CreateObjectADODB.Connection)
conn.ConnectionTimeout = 30
conn.CommandTimeout = 30
conn.Open (Provider=SQLOLEDB;UID=ourUserID;Password=ourPassword;Initial Catalog=ourCatalog;Data Source=ourdatabasename and location)

Should in fact be this:-

Code: Select all

Set conn = Server.CreateObject("ADODB.Connection")
conn.ConnectionTimeout = 30
conn.CommandTimeout = 30
conn.Open ("Provider=SQLOLEDB;UID=ourUserID;Password=ourPassword;Initial Catalog=ourCatalog;Data Source=ourdatabasename and location")

As d3mon says, you want to make sure it is going to run on the server, and not the client. Use Runat="server" in your script tag.

[D3mon]

if you use Runat="server" though, you won't be able to use a msgbox...

[malambing57]

Thanks

<blockquote id="quote"><font size="1" face="geneva, verdana, arial" id="quote">quote:<hr height="1" noshade id="quote">Originally posted by D3mon

if you use Runat="server" though, you won't be able to use a msgbox...
<hr height="1" noshade id="quote"></blockquote id="quote"></font id="quote">