dhtml scroller script help please!!

Dear all

This script works fine with and without the PHP part.
The bit that is causing it grief is the "onclick=" in the php.
If I use no onclick the page comes up in the new window fine.
As soon as I add the additional parms the script fails (the php works great on it's own!!)

My question is, how can I alter this dhtml in order to be able to control the size of the popup with my onclick command?

<div id="tester" style="position:relative; top:-35; left:-5">
<script language="JavaScript1.2">

/*
Scrollable Menu Links- By Dynamicdrive.com
For full source, TOS, and 100s DTHML scripts
Visit http://www.dynamicdrive.com
*/

//configure path for left and right arrows
var goleftimage='img/arrow_left.gif'
var gorightimage='img/arrow_right.gif'
//configure menu width
var menuwidth=439
//configure menu height
var menuheight=110
//configure scroll speed (1-10), where larger is faster
var scrollspeed=6
//specify menu content
var menucontents='<?php
include '/home/shoebiz/include/db.php';
$qResult = mysql_query ("SELECT * FROM shoe_tab WHERE style='Lowcut' AND instock='1'");
$nRows = mysql_num_rows($qResult);
for ($i=0; $i< $nRows; $i++){
$row = mysql_fetch_array($qResult);
$path = $row["path];
$small_image = $row["small_image];
echo "<a href=\"$path\" onClick=\"window.open('$path', 'myWin', 'toolbar=no, directories=no, location=no, status=yes, menubar=no, resizable=no, scrollbars=no, width=300, height=400, screenX=300,screenY=120,left=300,top=120'); return false\"><img src=\"$small_image\"></a>";
}
?>'

////NO NEED TO EDIT BELOW THIS LINE////////////

var iedom=document.all||document.getElementById
if (iedom)
document.write('<span id="temp" style="visibility:hidden;position:absolute;top:-100;left:-1000">'+menucontents+'</span>')
var actualwidth=''
var cross_scroll, ns_scroll
var loadedyes=0
function fillup(){
if (iedom){
cross_scroll=document.getElementById? document.getElementById("test2") : document.all.test2
cross_scroll.innerHTML=menucontents
actualwidth=document.all? cross_scroll.offsetWidth : document.getElementById("temp").offsetWidth
}
else if (document.layers){
ns_scroll=document.ns_scrollmenu.document.ns_scrol lmenu2
ns_scroll.document.write(menucontents)
ns_scroll.document.close()
actualwidth=ns_scroll.document.width
}
loadedyes=1
}
window.onload=fillup

function moveleft(){
if (loadedyes){
if (iedom&&parseInt(cross_scroll.style.left)>(menuwid th-actualwidth)){
cross_scroll.style.left=parseInt(cross_scroll.styl e.left)-scrollspeed
}
else if (document.layers&&ns_scroll.left>(menuwidth-actualwidth))
ns_scroll.left-=scrollspeed
}
lefttime=setTimeout("moveleft()",50)
}

function moveright(){
if (loadedyes){
if (iedom&&parseInt(cross_scroll.style.left)<0)
cross_scroll.style.left=parseInt(cross_scroll.styl e.left)+scrollspeed
else if (document.layers&&ns_scroll.left<0)
ns_scroll.left+=scrollspeed
}
righttime=setTimeout("moveright()",50)
}

if (iedom||document.layers){
with (document){
write('<table border="0" cellspacing="0" cellpadding="0">')
write('<td valign="middle"><a href=#" onMouseover="moveleft()" onMouseout="clearTimeout(lefttime)">[img]'+goleftimage+'[/img]</a> </td>')
write('<td valign="top">')
if (iedom){
write('<div style="position:relative;width:'+menuwidth+';">')
write('<div style="position:absolute;width:'+menuwidth+';heigh t:'+menuheight+';overflow:hidden;">')
write('<div id="test2" style="position:absolute;left:0;top:0">')
write('</div></div></div>')
}
else if (document.layers){
write('<ilayer width='+menuwidth+' height='+menuheight+' name="ns_scrollmenu">')
write('<layer name="ns_scrollmenu2" left=0 top=0></layer></ilayer>')
}
write('</td>')
write('<td valign="middle"> <a href="#" onMouseover="moveright()" onMouseout="clearTimeout(righttime)">')
write('[img]'+gorightimage+'[/img]</a>')
write('</td></table>')
}
}
</script>
</div>

mucho thankage.

Perhaps you could try this for your PHP

Code: Select all

<?php
include '/home/shoebiz/include/db.php';
$qResult = mysql_query ("SELECT * FROM shoe_tab WHERE style='Lowcut' AND instock='1'");
$nRows = mysql_num_rows($qResult);
for ($i=0; $i< $nRows; $i++){
$row = mysql_fetch_array($qResult);
$path = $row["path];
$small_image = $row["small_image];
echo "<a href=\"$path\" onClick=\"window.open('".$path."', 'myWin', 'toolbar=no, directories=no, location=no, status=yes, menubar=no, resizable=no, scrollbars=no, width=300, height=400, screenX=300,screenY=120,left=300,top=120'); return false\"><img src=\"$small_image\"></a>";
}
?>

I am afraid this made no difference.
My PHP works well when it is not in this script.
My feeling is that I will need to create an action within the dhtml portion.
Being a newb I can't tell where the new window is called from, the menucontent variable does not make it clear to me where to add the onclick java piece.

Maybe your PHP is inserting something strange into the string which stops your onClick from working. View the source and post that here.

Might be worth it to save your php in a seperate file and then just call it up and use it that way... I know with ASP coding you have to do that quite frequently.