Why is this not working!

Jack Franklin · #1 Mar 24th, 2008, 18:45

Ok, sort of related to my other thread but just a simple problem. Take this class:


class content {
var $selector;
var $table;
//START OF CONTENT CLASS
    function connect_db($user, $db) {
        $conn = mysql_connect("localhost", "root", "") or die(mysql_error());
        mysql_select_db($db, $conn) or die(mysql_error());
    }

    function get($thetable, $theselector) {
    $this->selector = $theselector;
    $this->table = $thetable;
    if (mysql_query("SELECT '$selector' FROM '$table'")) {
    echo 'Query Fine';
    }                
}
}

Nothing to tricky there? In the function GET it just adds the variables to the query.

On the home page:

PHP: Select all


$all = new content;
$all->connect_db(root, test);
$all->get(content, name);

Except it doesn't work. Obviously nothing displays, but I should get a nice message telling me it's all fine. Now, if I replace:

PHP: Select all


    if (mysql_query("SELECT '$selector' FROM '$table'")) {

With

PHP: Select all


    if (mysql_query("SELECT '$selector' FROM content")) {

It works. Anyone help me figure out why it wont work with a variable in there?

The error MySQL gives (added error report thingy) is:

Quote:

Originally Posted by Annoying MySQL

Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '''' at line 1

CloudedVision · #2 Mar 24th, 2008, 19:14

Try this as your SQL query:

PHP: Select all


mysql_query("SELECT `$selector` FROM `$table`")

Not sure if that would work, but give it a try.

Jack Franklin · #3 Mar 24th, 2008, 19:17

Nope, error. Wrong table name.

CloudedVision · #4 Mar 24th, 2008, 19:20

Hmmmm..... What's the query that the PHP is generating?

aihazm · #5 Mar 24th, 2008, 19:23

i think is just due to the quotes; try removing them :
'$table' -> $table

Jack Franklin · #6 Mar 24th, 2008, 20:00

No luck.

Oh well. Don't worry, I've given up anyway, it was getting to complex for me.

implrm · #7 Mar 25th, 2008, 08:17

Surely you are not naming the right variable i.e. you have $selector when you should be using $theselector or $this->selector

|This would also seem correct due to the error message as $selector isn't one of the defined variables therefore you will be passing "Select '' from '' " as a query.

Jack Franklin · #8 Mar 25th, 2008, 10:34

implrm you are a genius! As are the others! Turned out I had a typo, so aihazm's suggestion was right. The line now looks like:

PHP: Select all


    $sql = mysql_query("SELECT $this->selector FROM $this->table");

As I said this is my first time using OOP really so I'll be making some mistakes! Thanks all.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
CSS not working in IE?	Jgag	Web Page Design	2	Jun 5th, 2008 11:14
PNG - IE not working	Phixon	Web Page Design	3	Nov 30th, 2007 13:47
php not working?	gsquare567	PHP Forum	10	Apr 24th, 2007 18:52
PHP not working	toolmania1	PHP Forum	1	Nov 1st, 2006 05:57

		Webforumz.com > Main Forums > Program Your Website > PHP Forum
Why is this not working!