gaps in layout

http://www.wasteofinc.co.uk/jimi

stylesheet is http://www.wasteofinc.co.uk/jimi/style.css

if your looking on firefox, you can see there is a gap between the header and the banner, it shows the background through it aswell.

anyone tell me whats wrong please?


ta!

I played around with the code a bit and seem to have been able to get it working.

First thing I did was add this to the #banner div

Code: Select all

#banner{
    width: 800px;
    height: 30px;
    background: #000000;
    overflow: hidden;
            

}

This makes that black banner the correct height
This messed up the location of the image inside the banner. It had to do with the h1 that was around it.
So I changed the h1 to:

Code: Select all

h1{
    font-family: Helvetica, Arial, Sans-serif;
    color: white;
    font-size: 12px;
    padding: 0;
    margin: 0;
}

See if this fixes your issue!

you seem to have <h1> tags around an image in banner div remove this and you should be ok.

I would also add

Code: Select all

text-indent:-1999px;

to the header div. This way you can add a good description of your site, with keyphrases, and the text won't show up.

__________________
WelshStew Site Admin
If you think I've helped, click the "Thanks"
xtreme wales - extreme clothing | extreme sports shop | cheap sunglasses
WebForumz - facebook | LinkedIn

cheers guys! sorted now!

only a few more bits and pieces to go now!

jimi

plus screen readers will be saying aload of advertising things before they even here the nav menus! lol

That is the risk you have to take if you use this method.

__________________
Thanks
Marc
Staff Manager - Want to be a Moderator? PM me.

It all depends what you use it for. If you use it for keyword stuffing then yes, it is very naughty. But if you are using it to describe the image for when the css is turned off, then no. It's a desctiption of the item, like an "alt" tag, if you want to think of it that way.
Only if you put advertising in!

If you are looking to design your site to be DDA compliant, you should also be including skip to nav links at the top of the page, so screen readers won't even see / read this anyway.

__________________
WelshStew Site Admin
If you think I've helped, click the "Thanks"
xtreme wales - extreme clothing | extreme sports shop | cheap sunglasses
WebForumz - facebook | LinkedIn

So why not use just use the alt tag?

I'm not trying to play Devil's Advocate, i'm just interested.

Because google loves and weighs the H1 tag heavier than an alt tag. Keyword phrases in an h1 tag get more attention.

This is my point though, it's got nothing to do with accessibility and everything to do with SEO.

If it isn't visible, you're deliberately misleading Google and end users.

I didn't say you had to use the h1 tag in there. But you do bring up an interesting point.

But this is OT, so will pick up in a later thread.

__________________
WelshStew Site Admin
If you think I've helped, click the "Thanks"
xtreme wales - extreme clothing | extreme sports shop | cheap sunglasses
WebForumz - facebook | LinkedIn